react-component / react-component/dialog
static aria-label, no possibility to change for other language
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 455
- Forks
- 206
- Avg merge
- 12m
- Merged PRs (30d)
- 1
Description
There is no possibility to change aria-label either via a locale file or component properties. That breaks disability tests for other languages (in my case German).
https://github.com/react-component/dialog/blob/ecc8da988f03ef2d54e67f6e77a2f53483b812aa/src/Dialog/Content/Panel.tsx#L100
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Dialog/Content/Panel.tsx around line 100, where the static aria-label is referenced. Trace how the dialog content receives component properties or locale values, then define the supported customization behavior and verify that the label can be supplied for another language.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100