react-component / react-component/dialog
autoLock for portal should be configurable
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 455
- Forks
- 206
- Avg merge
- 12m
- Merged PRs (30d)
- 1
Description
This line
injects css from rc-portal
and it's not possible to opt out of it. it would be great if it was possible
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/DialogWrap.tsx around line 45 and inspect how it brings in rc-portal's scroll-locking behavior. Then read rc-portal's src/useScrollLocker.tsx around lines 27-30 to understand the injected CSS path. Done means Dialog provides a documented way to opt out of the portal's autoLock behavior, with coverage for the configurable case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100