react-component / react-component/collapse
Animation not working when accordion is in iframe
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 332
- Forks
- 140
- Avg merge
- 22h 19m
- Merged PRs (30d)
- 1
Description
I have a situation where we used your rc-collapse in our web app and in development it worked great. For some reasons we need to put it in iframe, and after we did it animation stopped working.
Accordion is still opening and closing tho, but without animation. It seems to me that it doesn't set the initial height (by inspecting it in Chrome), only final height. For example: when I want to open it first time, it only sets height: 200px. But without iframe, it correctly sets first 0px and 200px after that, so animation works.
Do you know why this might be happening?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the accordion behavior both inside and outside an iframe, then inspect the rendered height styles in Chrome as described. Trace the animation entry point in rc-collapse to determine why the initial height is skipped; done means opening and closing inside an iframe animates as it does outside one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100