react-component / react-component/checkbox
Checkbox Event Type Error
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 132
- Forks
- 109
- PR merge metrics
- No merged PRs in 30d
Description
Issue
- happens in
e.target.checked:Property 'checked' does not exist on type 'EventTarget'.
<Checkbox checked={x} onChange={(e) => setX(e.target.checked)} />
Suggestion
- in
index.d.ts
export interface Props {
onChange?: (e: Event) => void;
}
- to sth like following
interface Target extends Props {
checked: boolean;
}
interface ChangeEvent {
target: Target;
stopPropagation: () => void;
preventDefault: () => void;
nativeEvent: Object;
}
export interface Props {
onChange?: (e: ChangeEvent) => void;
}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the mentioned index.d.ts and the Checkbox onChange example first. Reproduce the TypeScript error for e.target.checked, then verify that the updated event typing accepts the example while preserving stopPropagation, preventDefault, and nativeEvent; the issue is done when the type error is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100