react-component / react-component/cascader
Search limit does not work as expected
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 233
- Forks
- 149
- Avg merge
- 10h 23m
- Merged PRs (30d)
- 2
Description
showSearch = {
limit: false,
}
It doesn't work correctly because the condition is formulated incorrectly
https://github.com/react-component/cascader/blob/master/src/hooks/useSearchConfig.ts#L24C9-L24C21
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/hooks/useSearchConfig.ts and inspect the condition around line 24, using the issue's showSearch.limit: false example as the starting case. Confirm that a false limit is handled as intended and verify that search results are no longer incorrectly constrained.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100