react-component / react-component/cascader

querySelect报错

Open
#357 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
233
Forks
149
Avg merge
10h 23m
Merged PRs (30d)
2

Description

https://github.com/react-component/cascader/blob/6ffd73324df75c915cf672aa14124c922f3b4d2a/src/OptionList/index.tsx#L157-L159

当代码中Selector中存在双引号时,代码将会抛出异常

  • 测试代码: document.querySelector('"asdlfjlksj"')

  • 异常信息如下所示

Uncaught DOMException: Failed to execute 'querySelector' on 'Document': '"asdlfjlksj"' is not a valid selector.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/OptionList/index.tsx lines 157-159 and reproduce the failure with document.querySelector('"asdlfjlksj"'). Trace how the selector is assembled or passed to querySelector, then add a regression test showing that a selector containing double quotes no longer throws and that existing selector behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.