rdmorganiser / rdmorganiser/rdmo

Error handling verification email (social) sign-up

Open
#192 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type:bug
Dominant language
Python
Stars
133
Forks
60
Avg merge
3d 14h
Merged PRs (30d)
21

Description

Descriptive summary
This addresses a bug (missing error handling) during (social) sign-up in combination with sending verification emails, eg. (third party) email sever issue.

Rationale
There is no reason the user is presented a 500 since he was signed up correctly and DEFAULT ACCOUNT_EMAIL_VERIFICATION (="optional"). The latter case ACCOUNT_EMAIL_VERIFICATION (="mandatory") will require separate attention.

.Actual behavior
When verification email can't be send, e.g. email sever problem, the new user is presented a 500 page. However, the user was correctly signed-up and is signed in, i.e. has access to /projects .

Expected behavior
When verification email can't be send, e.g. email sever problem, the new user is automatically directed to /projects page, since he has been signed in anyway.
In case of ACCOUNT_EMAIL_VERIFICATION (="mandatory") a error page is presented including contact to the service providers.

Related work

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the social sign-up flow and its verification-email handling, using ACCOUNT_EMAIL_VERIFICATION and the /projects redirect described in the issue. Verify the optional case keeps a successfully signed-in user out of the 500 page, while the mandatory case presents an appropriate error page with service-provider contact information.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
authentication
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.