rdmorganiser / rdmorganiser/rdmo
Make visibility info accessible for regular users
- Dominant language
- Python
- Stars
- 133
- Forks
- 60
- Avg merge
- 3d 14h
- Merged PRs (30d)
- 21
Description
Description
Visibility info is not displayed for regular users in project detail view.
History
An old PR was closed. (https://github.com/rdmorganiser/rdmo/pull/1710)
Start to work on it freshly in week 37
after these PRs are merged:
https://github.com/rdmorganiser/rdmo/pull/1715
https://github.com/rdmorganiser/rdmo/pull/1719
References from original PR
Jochens comments:
I think, the actual problem is that regular users cannot view the visibility object. The problem needs to be fixed in https://github.com/rdmorganiser/rdmo/blob/3.0.0/release/rdmo/projects/rules.py#L94 not in the front-end.
Ok, the easy part is to use
rules.add_perm('projects.view_visibility_object', is_project_member | is_visible | is_site_manager)
in rdmo/projects/rules.py and
if (permissions.can_view_visibility) {
store.dispatch(projectActions.fetchProjectVisibility(projectId))
}
in rdmo/projects/assets/js/project/store/configureStore.js.
The bigger problem is that site_managers cannot access /api/v1/core/sites/ and /api/v1/core/groups/. Lets talk about it in the meeting.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.