rcore-os / rcore-os/rCore-Tutorial-v3
Bug in user/src/bin/sig_simple2.rs
Open
Nobody has claimed this yet.
bug
- Dominant language
- Rust
- Stars
- 2.1k
- Forks
- 560
- PR merge metrics
- No merged PRs in 30d
Description
The 2nd parameter of kill here should be 10, not 1<<10. Otherwise you'll get 1<<(1<<10) in os/src/syscall/process.rs#sys_kill
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with user/src/bin/sig_simple2.rs at the referenced kill call, then read os/src/syscall/process.rs at sys_kill to understand how the second parameter is handled. Done means the call passes the intended signal value and the resulting expression no longer applies an unintended nested shift.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100