rcore-os / rcore-os/rCore-Tutorial-v3

syscall numbers of sys_open and sys_openat are confusing

Open
#68 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2.1k
Forks
560
PR merge metrics
No merged PRs in 30d

Description

In os/src/syscall/mod.rs#L1 the syscall number for sys_open is 56, how ever in this refrence 56 points to sys_openat

Also, in rcore-os/rcore_tutorial_tests/ the number 56 is also pointing to sys_openat. I'm not sure if that was intended here. 🤔

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the syscall declarations in os/src/syscall/mod.rs and user/src/syscall.rs with the linked RISC-V syscall reference. Determine whether number 56 is intended to identify sys_open or sys_openat, then check the related syscall usage and tests. Done means the numbering and its naming are consistent across the referenced files.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.