[pcloud] OpenWriterAt: Default values for multi threaded upload
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 59.8k
- Forks
- 5.4k
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 48
Description
The associated forum post URL from https://forum.rclone.org
Follow up on #8147
What is your current rclone version (output from rclone version)?
Latest master
What problem are you are trying to solve?
As @ncw described it:
We don't have a way currently for a backend to give a hint as to what chunk size it prefers for OpenWriterAt only for OpenChunkWriter. It would be easy enough to make one though and I think it is a good idea.
How do you think rclone should be changed to solve that?
As far as I see there are two approaches:
- Add a way for backends to give hints for buffer size etc. in OpenWriterAt. (Similar to ChunkWriterInfo for OpenChunkWriter)
- Implement OpenChunkWriter in pcloud.
IMHO 1/ is more invasive to the code base but cleaner and consistent with the ChunkWriter. Your thoughts @ncw?
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the OpenWriterAt and OpenChunkWriter entry points and the ChunkWriterInfo reference in the backend code, then compare how pcloud handles uploads. Resolve which of the two proposed approaches is accepted; done means pcloud has the desired multi-threaded upload defaults and the relevant backend behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, cloud
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100