control flow

Prologue

#19 defines an existing problem where the promise chain is broken on concurrent control flow types (Promises and callbacks).

Problem

Implementing both of them at once is a design flaw and it should be noted that Node dictates a strict choice between the two. (Look at request and its accompanying request-promise catalogue.)

Solution

A simple callback adapter can be placed and since the world is moving on to Promises, it would make for a sensible default. Then, on initialization, the following can be passed in the options object:

const Razorpay = require( 'razorpay-sdk' );
const apiObject = new Razorpay( { controlFlow: 'callbacks' } );

Tags

Enhancements, broken, bugs

(Direct CC: @captn3m0)

Start by reading issue #19 and the referenced request/request-promise catalogue, then inspect the SDK initialization and its current promise and callback handling. Done means choosing Promises as the default while supporting an explicit controlFlow: 'callbacks' option through a callback adapter.