razorpay / razorpay/razorpay-node

[Feature]: Allow passing additional params to payments.all method

Open
#456 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
243
Forks
129
PR merge metrics
No merged PRs in 30d

Description

🚀 Feature Proposal

Similar to paymentLinks.all, which pass additional params to underlying GET request

https://github.com/razorpay/razorpay-node/blob/9737ef17342b8a551f7af2413c8d24df559accc8/lib/resources/paymentLink.js#L104-L109

payments.all method should also pass additional params to GET request

https://github.com/razorpay/razorpay-node/blob/9737ef17342b8a551f7af2413c8d24df559accc8/lib/resources/payments.js#L30-L35

Suggested Solution

Add ...params in data before from, to, count etc here

https://github.com/razorpay/razorpay-node/blob/9737ef17342b8a551f7af2413c8d24df559accc8/lib/resources/payments.js#L30-L35

Alternatives

Directly using api.get method

Additional Information

Node JS: 22.x
Razorpay Node: 2.9.6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/resources/payments.js at the referenced payments.all implementation, then compare it with lib/resources/paymentLink.js at the referenced paymentLinks.all implementation. Confirm how additional parameters are passed to the GET request and preserve the existing from, to, and count options; the change is done when payments.all forwards those parameters as requested.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.