razorpay / razorpay/razorpay-node

partial payment and notes not working together

Open
#327 4 comments 0 reactions 1 assignee View on GitHub

@ankitdas13 is already working on this.

Since Dec 6, 2022.

bug
Dominant language
JavaScript
Stars
243
Forks
129
PR merge metrics
No merged PRs in 30d

Description

Steps to reproduce the behavior

During Creating order in Nodejs using option created by following code.

Expected behavior

if there are partial amount, create order with partial payment or create full payment order

Actual behavior

when there are partial payment, returned error notes["anything"] are extra document, error code 400. without partial payment, zero partial payment working as expected.

Code snippets
if ((first_payment_min_amount != undefined || first_payment_min_amount != null) && (first_payment_min_amount > 0 && first_payment_min_amount < amount)) {
    var option = {
      notes: notes,
      amount: amount,  // amount in the smallest currency unit
      //currency: "INR",
      partial_payment: true,
      first_payment_min_amount: first_payment_min_amount,
      receipt: receipt,

    };

  }
  else {

    option = {
      "amount": amount,  // amount in the smallest currency unit
      "currency": "INR",

      "receipt": receipt,
      "notes": notes
    };
  }
Node version

Node 16

Library version

2.8.4

Additional Information

currently I can create more than one order with single receipt, both through api and nodejs. Dont know its new feature or bug. Previously I could create only one order against one receipt.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.