StencilClient configured with ondemandRefresh doesn't refresh for nested protos

Open
#77 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
32/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
backend

Research direction

Start with ProtoParserWithRefresh and the Stencil Client's ondemand refresh path. Reproduce deserialization after adding a field to a nested proto or modifying an enum, then verify that unknown fields at nested levels trigger a cache refresh.

Written by the indexing model from the issue text.

Description

bug

Describe the bug
Stencil Client when configured for ondemand refresh it uses ProtoParserWithRefresh which checks for any unknownfields and refreshes the cache, but unknownfields does check only in the root proto, so for nested protos if there are new fields being added it won't refresh the cache.

To Reproduce
Create a proto & add a new field at a nested level or modify an enum this should be reproduced in that case while deserializing

Dominant language
Go
Stars
237
Forks
42
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from raystack/stencil

All issues in raystack/stencil

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.