Replace NewCascadeDeleter positional arguments with a config struct
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 344
- Forks
- 47
- Avg merge
- 4d 4h
- Merged PRs (30d)
- 26
Description
NewCascadeDeleter takes 17 positional dependencies after the org-delete cleanup stack (#1838). Every new dependency is appended positionally, which is easy to get wrong since several arguments share the same interface shape.
Replace the positional list with a struct (e.g. deleter.Deps) so construction is named and order-independent.
Raised in review: https://github.com/raystack/frontier/pull/1838#discussion_r3711259260
🤖 Generated with Claude Code
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating NewCascadeDeleter and the org-delete cleanup stack introduced in PR #1838. Read its callers and the deleter package to identify all 17 dependencies and their construction sites. Replace the positional construction with the named dependency struct, then run the relevant Go tests and confirm the project builds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100