Give permission responses a lossless replacement for the deprecated namespace and name fields
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 344
- Forks
- 47
- Avg merge
- 4d 4h
- Merged PRs (30d)
- 26
Description
internal/reconcile/permission_reconciler.go, cmd/permission.go, and assertions in test/e2e/regression/service_registration_test.go read the deprecated namespace/name response fields because the replacement key round-trips lossily: a namespace without a slash gains a /default suffix through SplitNamespaceResource, and names containing dots fail to split in PermissionNamespaceAndNameFromKey. Fix the key scheme (or add a faithful field), then migrate these readers.
Part of #1782.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with internal/reconcile/permission_reconciler.go and cmd/permission.go, then inspect SplitNamespaceResource and PermissionNamespaceAndNameFromKey to reproduce the lossy round-trip cases. Update the response readers and the assertions in test/e2e/regression/service_registration_test.go so namespaces without slashes and names containing dots remain faithful, then run the relevant regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100