Remove the deprecated API usage acknowledged in the staticcheck rollout
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 344
- Forks
- 47
- Avg merge
- 4d 4h
- Merged PRs (30d)
- 26
Description
PR #1781 annotated every remaining use of a deprecated API with //nolint:staticcheck. Each annotation is deliberate, but all of them are debt. This issue tracks removing them. The sites, grouped by what unblocks each:
Actionable now
- New Relic go-agent v2 → v3 —
pkg/db/db.goandinternal/store/spicedb/relation_repository.goimport the deprecated v2 package. Migrating means the v3 import path and the reworked transaction/segment APIs at every telemetry call site. - e2e billing tests —
test/e2e/regression/billing_test.gouses the deprecatedUpdateBillingAccountLimitsRPC as a setup tool.UpdateBillingAccountDetailssets the samecredit_min(note it also writesdue_in_days).
Blocked on the API dropping the deprecated request fields
Handler fallbacks that must stay while old clients send the old shapes:
internal/api/v1beta1connect/billing_usage.go—since(superseded bystart_range)internal/api/v1beta1connect/billing_subscription.go— flatplan/immediate(superseded byplan_change)internal/api/v1beta1connect/permission.go—namespace/namebody fields (superseded bykey)internal/api/v1beta1connect/permission_check.go— split object fields (superseded byresource)cmd/serve.go— theFullyConsistentconfig flag (superseded byconsistency)cmd/seed.go— seed data sends the deprecated permission body shape
Blocked on a lossless replacement for the deprecated response fields
internal/reconcile/permission_reconciler.go, cmd/permission.go, and the assertions in test/e2e/regression/service_registration_test.go read the deprecated namespace/name response fields. The replacement key round-trips lossily today: a namespace without a slash gains a /default suffix through SplitNamespaceResource, and names containing dots fail to split. These readers can migrate once key (or another field) carries the exact values.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with PR #1781 and the actionable files: pkg/db/db.go, internal/store/spicedb/relation_repository.go, and test/e2e/regression/billing_test.go. Trace the deprecated telemetry calls and billing setup usage, then check the listed blocked handlers and readers to understand their dependencies. Done means the actionable deprecated usages are removed and the remaining annotations have a clear API dependency preventing removal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend, observability, testing
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100