Should the service or ingress annotations be part of the charts
Nobody has claimed this yet.
- Dominant language
- Go Template
- Stars
- 41
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
Summary
Should the service or ingress annotations be part of the charts, since the current values are based on our internal infra, and users can have their own different controllers?
Example:
- Service annotation
service:
annotations:
projectcontour.io/upstream-protocol.h2c: tcp
https://github.com/odpf/charts/blob/main/stable/guardian/values.yaml#L33
- Ingress annotation:
ingress:
enabled: true
annotations:
kubernetes.io/ingress.class: contour
https://github.com/odpf/charts/blob/main/stable/guardian/values.yaml#L66
Related discussion - https://github.com/odpf/charts/pull/66#discussion_r940912752
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with stable/guardian/values.yaml at the service and ingress annotation sections, then inspect the related chart templates to see how those values are rendered. Compare the current defaults with the linked pull request discussion and verify that users can provide controller-specific annotations without retaining internal defaults.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- devops
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100