DataView: expose classNames for filter-chip internals and loader rows
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 70
- Forks
- 13
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 8
Description
Summary
DataView.List renders its rows, cells, and group headers internally, and exposes classNames hooks for them (root, header, headerCell, row, cell, groupHeader, plus per-column cell/header and Filters.classNames.filterChips/addFilter). Two rendered parts still have no hook, so theming them means targeting hashed CSS-module classes ([class*="data-view-module_…"]), which are internal and can change between releases.
What has no hook
-
Filter-chip internals.
Filters.classNames.filterChipslands on the chip root only. The inner parts can't be reached:chip-label,operationText,operationValue,selectValue,removeIcon,removeIconContainer,leadingIcon. -
Loader / skeleton rows. When
isLoadingrenders placeholder rows, there's no hook on the loader container or its rows —DataViewListClassNamescovers real rows, not the loading state.
Proposed change
- Add a
classNamesobject toFilterChip(surfaced throughFilters) covering its inner parts. - Add a
loader(and/or loader-row) key toDataViewListClassNames.
Both follow the pattern the existing hooks already use: read an optional string from props, apply it to the element DataView already renders.
Willing to contribute
Happy to open a PR if the approach looks right.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at DataView.List and the FilterChip implementation, then trace how Filters.classNames.filterChips and DataViewListClassNames are applied to rendered elements. Add hooks for the listed filter-chip internals and the loading container or rows, with the existing classNames patterns preserved; done means both areas can be themed without hashed CSS-module selectors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100