raystack / raystack/apsara

DataView: expose classNames for filter-chip internals and loader rows

Open
#846 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
70
Forks
13
Avg merge
2d 5h
Merged PRs (30d)
8

Description

Summary

DataView.List renders its rows, cells, and group headers internally, and exposes classNames hooks for them (root, header, headerCell, row, cell, groupHeader, plus per-column cell/header and Filters.classNames.filterChips/addFilter). Two rendered parts still have no hook, so theming them means targeting hashed CSS-module classes ([class*="data-view-module_…"]), which are internal and can change between releases.

What has no hook

  1. Filter-chip internals. Filters.classNames.filterChips lands on the chip root only. The inner parts can't be reached: chip-label, operationText, operationValue, selectValue, removeIcon, removeIconContainer, leadingIcon.

  2. Loader / skeleton rows. When isLoading renders placeholder rows, there's no hook on the loader container or its rows — DataViewListClassNames covers real rows, not the loading state.

Proposed change

  1. Add a classNames object to FilterChip (surfaced through Filters) covering its inner parts.
  2. Add a loader (and/or loader-row) key to DataViewListClassNames.

Both follow the pattern the existing hooks already use: read an optional string from props, apply it to the element DataView already renders.

Willing to contribute

Happy to open a PR if the approach looks right.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at DataView.List and the FilterChip implementation, then trace how Filters.classNames.filterChips and DataViewListClassNames are applied to rendered elements. Add hooks for the listed filter-chip internals and the loading container or rows, with the existing classNames patterns preserved; done means both areas can be themed without hashed CSS-module selectors.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.