[Browser Bookmarks] Extension fav icons don't match browser fav icons
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 7.8k
- Forks
- 6.9k
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 442
Description
Extension
https://www.raycast.com/raycast/browser-bookmarks
Description
The old (private) extension handled this nicely, I assume by reading from the browser's favicon DB instead of raycast's getFavIcon.
There are two main places where I've found getFavIcon to be worse than the (assumed) old approach.
- Urls behind authentication
- Url redirects
Steps To Reproduce
Use-case 1:
- Bookmark a url behind authentication (my repro case: https://[subdomain].atlassian.net)
- Search for the bookmark in the bookmark browser extension, the displayed icon is the fallback.
Use-case 2:
- Bookmark a url with a redirect (my repro case: https://mail.google.com)
- Search for the bookmark in the bookmark browser extension, the displayed icon is the fallback.
Current Behaviour
Icon displayed by bookmark browser extension is the fallback icon.
Expected Behaviour
Icon displayed by bookmark browser extension matches the fav icon in my browser.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Browser Bookmarks extension and locate its use of getFavIcon. Reproduce the authenticated URL and redirect cases described in the issue, then compare the displayed icons with those in the browser. Done means both cases display the browser's favicon instead of the fallback icon.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100