Static binding not reserved ?
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript, typescript
- Domain
- networking
Research direction
Start at the _selectAdress function and inspect how static bindings, leases, and known addresses are handled; review the static configuration option, including when it is a function. Determine which reservation behavior is chosen, then verify that a statically bound address cannot be incorrectly allocated to another client.
Written by the indexing model from the issue text.
Description
It seems that the static bindings are not "reserved".
In the _selectAdress function, if a static binding exists, then the IP is returned, but it's never checked if the IP is already in lease or not.
Two possibilities to solve :
-
Let the static return like that, but if the address is already in lease, force the client who owns this address to change (renew)
-
Get all the static addresses and add them in the "known addresses" so that it is reserved to the binded MAC, something like :
for(var bind in static) {
ips.push(static[bind]);
}
This solution seems impossible if the static option in the config is a function ...
Let me know if I'm wrong on this issue.
- Dominant language
- TypeScript
- Stars
- 313
- Forks
- 70
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rawify/dhcp.js
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Big Fork. Open
Difficulty 5/5 Over a week Newbie friendliness 15/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
dhcp-proxy Open
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
DHCP Dashboard Openenhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
Similar issues
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 76/100
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
vercel/react-tweet#225 ·