ravi688 / ravi688/BuildMaster

Bug: Hypen in target name is causing problems

Open
#64 0 comments 0 reactions 1 assignee View on GitHub

@ravi688 is already working on this.

Since Feb 16, 2025.

bug
Dominant language
C++
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Example Json:

{
    "project_name": "Disassembler",
    "canonical_name": "disasm",
    "description" : "Disassembler for V3D Shader Binary compiled using VSC",
    "dependencies" : [
     
    ],
    "include_dirs": "include",
    "debug_defines" : [
        "-DDISASM_DEBUG"
    ],
    "release_defines" : [
        "-DDISASM_RELEASE"
    ],
    "targets": [
        {
            "name": "v3d-disasm",
            "is_executable": true,
            "is_install" : true,
            "sources": [
                "source/main.c"
            ]
        }
    ],
    "sources" : [
        "source/disasm.c"
    ]
}

Error:

meson.build:168:0: ERROR: Assignment target must be an id.
]
^

Why?:
// file: meson.build

....
v3d-disasm_sources_bm_internal__ = [
'source/main.c'
]
v3d-disasm_include_dirs_bm_internal__ = [

]
v3d-disasm_dependencies_bm_internal__ = [

]
....

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.