ravi688 / ravi688/BuildMaster

Bug: build_master.json generated by init is incorrect

Open
#55 0 comments 0 reactions 1 assignee View on GitHub

@ravi688 is already working on this.

Since Feb 14, 2025.

bug
Dominant language
C++
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Running build_master init --name=MeshLib --canonical_name=meshlib generates the following json file:

{
    "project_name": "MeshLib",
    "canonical_name": "meshlib",
    "include_dirs": "include",
    "targets": [
        {
            "name": "meshlib",
            "is_executable": true,
            "sources": [
                "source/main.c"
            ]
        }
    ]
}

(Bug) What is wrong with it?:
Notice that "include_dirs" is of type array, so it must have value as [ "include" ], not "include".

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.