should audio_i2s_setup claim the dma channel requested by the user?

Open
#48 3 comments 0 reactions 1 assignee View on GitHub

@peterharperuk is already working on this.

Since Nov 18, 2022.

Assessment

This issue has not been assessed yet.

Description

audio_i2s_setup has a config passed in which includes the dma channel to use. It claims this dma channel. But should the caller claim the channel instead? As there's no guarantee the channel will be free by the time audio_i2s_setup tries to claim it?

Dominant language
C
Stars
605
Forks
155
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from raspberrypi/pico-extras

All issues in raspberrypi/pico-extras

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.