i2c1-pi5 dtbo load error on 6.1

Open
#5,652 3 comments 0 reactions 1 assignee View on GitHub

@pelwell is already working on this.

Since Oct 17, 2023.

Assessment

This issue has not been assessed yet.

Description

Describe the bug

Hello.

On commit 392b9849c8d147c25557fea5d6dbcddbcb9e72d5

Trying to load the dtbo i2c1-pi5 on pi5:

dtoverlay i2c1-pi5

will lead to the following error:

[  121.186991] i2c_designware 1f00074000.i2c: prop pinctrl-0 index 0 invalid phandle
Steps to reproduce the behaviour

dtoverlay i2c1-pi5

Device (s)

Other

System

Recalbox 9.2 alpha

# vcgencmd version
2023/09/13 11:37:06 
Copyright (c) 2012 Broadcom
version 9d494316 (release) (embedded)
# uname -a
Linux RECALBOX 6.1.57-v8_16k #1 SMP PREEMPT Sun Oct 15 15:54:49 CEST 2023 aarch64 GNU/Linux
Logs
dmesg
[  121.186991] i2c_designware 1f00074000.i2c: prop pinctrl-0 index 0 invalid phandle
Additional context

It seems to be related to the target = <&frag0>; in i2c1-pi5-overlay.dts.

Using the i2c1 target in fragments fix the issue, but may I suggest using the same pattern for i2c0 and i2c1 than the i2c2-pi5-overlay.dts, that also fix the issue.

/dts-v1/;
/plugin/;

/{
	compatible = "brcm,bcm2712";

	fragment@0 {
		target = <&i2c1>;
		frag0: __overlay__ {
			status = "okay";
			clock-frequency = <100000>;
			pinctrl-0 = <&rp1_i2c1_2_3>;
		};
	};

	__overrides__ {
		pins_2_3 = <&frag0>,"pinctrl-0:0=", <&rp1_i2c1_2_3>;
		pins_10_11 = <&frag0>,"pinctrl-0:0=", <&rp1_i2c1_10_11>;
		baudrate = <&frag0>, "clock-frequency:0";
	};
};

Thank you for the hard work on pi5 hardware and kernel/mesa support, it runs almost flawlessly!

Dominant language
C
Stars
13.2k
Forks
5.5k
Avg merge
2d 21h
Merged PRs (30d)
21

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from raspberrypi/linux

All issues in raspberrypi/linux

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.