Linux 6.3 gpio-pwm fails to compile

Open
#5,472 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c, linux, raspberry-pi

Research direction

Start in drivers/gpio/gpio-pwm.c, in pwm_gpio_probe around line 104, and reproduce the Linux 6.3 build with gpio-pwm enabled. Inspect the gpio_chip API change involving of_node and fwnode, then verify that the Raspberry Pi kernel compiles successfully with this driver enabled.

Written by the indexing model from the issue text.

Description

Describe the bug

drivers/gpio/gpio-pwm.c: In function 'pwm_gpio_probe':
drivers/gpio/gpio-pwm.c:104:22: error: 'struct gpio_chip' has no member named 'of_node'; did you mean 'fwnode'?

I've just been commenting out the line. Not sure that's the correct solution, but it is the only line of code that attempts to use gpio_chip.of_node.

Steps to reproduce the behaviour

Attempt to compile 6.3 tree with gpio-pwm enabled.

Device (s)

Raspberry Pi 4 Mod. B

System

uname aarch64
firmware is latest
distro is Xilka

Logs

No response

Additional context

No response

Dominant language
C
Stars
13.2k
Forks
5.5k
Avg merge
2d 21h
Merged PRs (30d)
21

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from raspberrypi/linux

All issues in raspberrypi/linux

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.