Compile problem due to patch from raspberry pi
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- c, linux, raspberry-pi
- Domain
- build-system, operating-systems
Research direction
Start by reproducing the arm64 cross-compilation failure with the Raspberry Pi patches applied. Inspect drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.h and drivers/gpu/drm/msm/dp/dp_display.c, particularly their drm_panel.h and drm_connector.h includes. Done means the Debian kernel builds successfully with the affected patches, using either the proposed includes or an agreed header-definition change.
Written by the indexing model from the issue text.
Description
Describe the bug
I am compiling a Debian kernel with all patches from raspberry pi applied.
This breaks since a few kernel revisions due to the following patch:
From 1a5ac44f2640e1e5f184dea59456644a8fe6854e Mon Sep 17 00:00:00 2001
From: Dave Stevenson dave.stevenson@raspberrypi.com
Date: Tue, 1 Feb 2022 12:20:20 +0000
Subject: [PATCH 599/667] drm/panel: Add and initialise an orientation field to drm_panel
The following quick fix seems to cure the compile problems for me:
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.h
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.h
@@ -7,6 +7,7 @@
#ifndef __MDP4_KMS_H__
#define __MDP4_KMS_H__
+#include <drm/drm_connector.h>
#include <drm/drm_panel.h>
#include "msm_drv.h"
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -10,6 +10,7 @@
#include <linux/component.h>
#include <linux/of_irq.h>
#include <linux/delay.h>
+#include <drm/drm_connector.h>
#include <drm/drm_panel.h>
#include "msm_drv.h"
Can you please review this and include this in your rpi patches for kernel 5.16 and 5.17?
Instead of these includes, maybe you want to move the definition of "enum drm_panel_orientation"
from drom_connector.h to drm_panel.h instead?
Thanks a lot,
best regards from Germany,
Florian La Roche
Steps to reproduce the behaviour
Cross-recompile Debian kernel together with raspberry pi patches applied.
Device (s)
Other
System
arm64 build, crosscompile from amd64
Logs
No response
Additional context
No response
- Dominant language
- C
- Stars
- 13.2k
- Forks
- 5.5k
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 21
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from raspberrypi/linux
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
raspberrypi/linux#7415 · 2 comments · 1 reaction ·
-
rp1-cfe doesn't forward V4L2_EVENT_SOURCE_CHANGE event from csi-2 sensor driver to userspace app Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
raspberrypi/linux#7399 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
raspberrypi/linux#7357 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
raspberrypi/linux#7054 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
raspberrypi/linux#7634 · 8 comments · 1 reaction ·
All issues in raspberrypi/linux
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
zephyrproject-rtos/zephyr#119726 ·
-
[Bounty proposal] fix(web): memory insights count an evening memory on the next day ($25 proposed) Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
BasedHardware/omi#15320 ·
-
[adam] AdamNet network read doesn't cap to MAX_ADAM_PACKET_LEN, overflows client receive buffers Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
FujiNetWIFI/fujinet-firmware#1649 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
HarbourMasters/Shipwright#7229 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
riscv-software-src/riscv-isa-sim#2435 · 1 comment ·