disable genet receiver when disabling dma in firmware instead of linux genet reset

Open
#1,882 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
linux

Research direction

Start by reading the referenced Raspberry Pi Linux commit b65b82fbd2ce90c3e96cb10e1e21a784a60b6a9a and the linked netdev discussion. Identify the firmware component handling BCM GENET DMA disable and determine whether receiver reset belongs there; done means a firmware build implements the required reset and can be tested without the Linux reset patch.

Written by the indexing model from the issue text.

Description

I was trying to upstream https://github.com/raspberrypi/linux/commit/b65b82fbd2ce90c3e96cb10e1e21a784a60b6a9a (net: bcmgenet: Reset RBUF on first open) ( context: https://lore.kernel.org/netdev/47ba4ef5a42fe7412d7e3432a0995464@rmail.be/T/ ):

And there was discussion of that it would be better to fix this in firmware, rather than try to make the workaround in kernel.

The suggestion is that likely DMA disable is not enough, and receiver reset is necessary too.

Would it be possible to try to get this fix in the firmware? I can easily test a firmware build of this (without the reset patch).

Dominant language
No language data
Stars
5.6k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from raspberrypi/firmware

All issues in raspberrypi/firmware

Similar issues

More Embedded & IoT issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.