Any user can edit the wiki section

Open
#1,735 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
20/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
github

Research direction

Start with the Raspberry Pi firmware GitHub wiki, especially the Mailbox property interface page and its revision history, then inspect the wiki footer link mentioned in the report. Done would require a documented decision on whether edits need review, an appropriate contribution path if needed, and correction of the dead footer link.

Written by the indexing model from the issue text.

Description

Describe the bug
I'm not sure if this is an intended behavior or not but last week I noticed that I have the permissions to edit the wiki entries with no restrictions.

To reproduce
Try to edit the wiki as user without write permissions to the repo

Expected behaviour
There should be a way to suggest changes to the wiki without modifying the and only when user that maintains this repo could approve once he verified it.

Actual behaviour
I (a random github user) shouldn't be able to edit your wiki

System
All systems

Additional context
Perhaps I misunderstand your maintain model of the wiki, but last week when I wanted to add some details to the wiki I was shocked to see that I can simply edit, after that I expected that my edit will be reverted in a couple of hours/days, but until now its there.
I dont think my contribution is bad Im just shocked there was no some kind of review process before other people saw my edit when they searched for official info about the mailbox property interface (see last revision (number 100) is made by me - https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface)

I actually have some more details Id like to add so Ill be happy to hear what is the proffered way to suggest those changes.

Also the link in the footer that welcomes to contribute to the wiki is dead and points to 404.

Edit:

Since I received no response in the last 3 weeks I added another detail I discovered that was not documented.

Dominant language
No language data
Stars
5.6k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from raspberrypi/firmware

All issues in raspberrypi/firmware

Similar issues

More Security issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.