probe_oen.pio doesn't set SWCLK as a sideset pin
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- c
- Domain
- embedded-iot
Research direction
Compare the sideset configuration in src/probe.pio around line 104 with src/probe_oen.pio around line 83. Read the surrounding PIO setup to determine whether probe_oen.pio should configure SWCLK as a sideset pin or whether its comment is incorrect. Done means the intended behavior is established and the code and comment agree.
Written by the indexing model from the issue text.
Description
Whilst looking at #194 I noticed that probe.pio says:
// Set SWCLK as a sideset pin
sm_config_set_sideset_pins(sm_config, PROBE_PIN_SWCLK);
(i.e. the comment matches the code), whereas probe_oen.pio says:
// Set SWDIOEN and SWCLK as sideset pins
sm_config_set_sideset_pins(sm_config, PROBE_PIN_SWDIOEN);
i.e. despite what the comment says, it doesn't actually set SWCLK as a sideset pin.
Not being familiar with how this code works, I don't know if probe_oen.pio is accidentally missing a sm_config_set_sideset_pins(sm_config, PROBE_PIN_SWCLK); line, or whether the comment simply needs updating to // Set SWDIOEN as a sideset pin ? 🤷♂️
- Dominant language
- C
- Stars
- 1.2k
- Forks
- 363
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from raspberrypi/debugprobe
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
raspberrypi/debugprobe#210 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
raspberrypi/debugprobe#206 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
raspberrypi/debugprobe#202 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
raspberrypi/debugprobe#185 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 30/100
raspberrypi/debugprobe#177 · 1 reaction ·
All issues in raspberrypi/debugprobe
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
zephyrproject-rtos/zephyr#119726 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
api7/lua-resty-saml#63 ·
-
[Bounty proposal] fix(web): memory insights count an evening memory on the next day ($25 proposed) Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
BasedHardware/omi#15320 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
[adam] AdamNet network read doesn't cap to MAX_ADAM_PACKET_LEN, overflows client receive buffers Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
FujiNetWIFI/fujinet-firmware#1649 · 2 comments ·