rapidsai / rapidsai/shared-actions
proposal: start versioning this repo?
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 1
- Forks
- 15
- Avg merge
- 8h 7m
- Merged PRs (30d)
- 8
Description
Description
Across RAPIDS CI today, projects pin to @main of this repo, like this:
check-nightly-ci:
runs-on: ubuntu-latest
steps:
- name: Check if nightly CI is passing
uses: rapidsai/shared-actions/check_nightly_success/dispatch@main
(rapidsai/cudf - .github/workflows/pr.yaml)
That makes the choices for merging breaking changes here painful:
- option 1: immediately merge a bunch of PRs across RAPIDS after merging one to
mainhere (what I did for #94) - option 2 open PRs in RAPIDS repos temporarily pinning them to a specific commit, then go open new ones pinning to
@mainafter merging here - option 3: just merge here and accept CI being broken in other repos until they adjust to changes
We should instead publish versioned tags here and pin to those tags.
Benefits of this work
Makes breaking changes less costly:
- reduced need for coordination and admin-merges across all of RAPIDS
- reduced need for in-progress PRs to update to latest
mainimmediately
And reducing the cost of breaking changes should hopefully make it less likely we hold around backwards compatibility (complexity!) we otherwise don't want in this repo.
Acceptance Criteria
- this project uses versioned tags
- all RAPIDS repos refer to this repo by tags or commit SHAs, not
@main
Approach
- tag
@mainas of when this work begins as@v1 - update all RAPIDS uses of these actions to
@v1 - add documentation here about the versioning, noting that:
- the
@v1tag should be updated after non-breaking changes are merged - a new major-version tag like
@v2should be created when breaking changes are merged
- the
What about minor versions?
Once we've moved RAPIDS repos away from using @main, the tag structure can follow any patterns we find useful. I (@jameslamb) personally think only updating tags for breaking changes is sufficient to minimize disruptions, and that it minimizes how often we have to do all-of-rapids updates of those tag references.
Notes
N/A
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the cited cudf .github/workflows/pr.yaml example and search RAPIDS repositories for uses of this repository pinned to @main. Review the proposed v1 tagging and documentation approach, then track the tag updates across RAPIDS. Done means versioned tags exist, RAPIDS references use tags or commit SHAs, and the versioning guidance is documented here.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, github-actions, shell
- Domain
- ci-cd, devops, release
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100