`df.join` should accept singleton arguments, not just iterable.
Open
@thomcom is already working on this.
Since Sep 1, 2022.
- Dominant language
- TypeScript
- Stars
- 211
- Forks
- 29
- Avg merge
- 17h 30m
- Merged PRs (30d)
- 1
Description
join uses forEach to join across the on: keys. A common use case of join is with a single join column, so we should accept the use of a single join argument.
keys_df.join({other: target_df, on: 'keys', how: 'inner'});
vs
keys_df.join({other: target_df, on: ['keys'], how: 'inner'});
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.