rapidsai / rapidsai/node

Refactor `CUDF` typescript exports

Open
#272 0 comments 0 reactions 1 assignee View on GitHub

@matekdev is already working on this.

Since Jul 19, 2021.

Dominant language
TypeScript
Stars
211
Forks
29
Avg merge
17h 30m
Merged PRs (30d)
1

Description

CUDF currently uses an old way to export .cpp types which involves creating and exporting interfaces. For example...

export interface Table {...
export const Table: TableConstructor = CUDF.Table;

in table.ts

We can avoid doing these exports by following an export method currently done by our CUDA library. Consider the following files noda_cuda.ts cuda/src/addon.ts. These files use a different way to export the .cpp types. We should do the same for CUDF.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.