rapidsai / rapidsai/docker

Stop uploading notebook test results to downloads.rapids.ai

Open
#775 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

improvement ops testing
Dominant language
Shell
Stars
87
Forks
59
Avg merge
22h 56m
Merged PRs (30d)
4

Description

Description

This project currently runs a bunch of RAPIDS notebooks, collects their logs in a few tarballs, and uploads those tarballs to downloads.rapids.ai.

See paths like the following at downloads.rapids.ai:

ci/docker/pull-request/{pr_number}/{commit_sha}/test_notebooks_output_*.tar.gz

That comes from here:

https://github.com/rapidsai/docker/blob/bebddd8d3ef10d19773bc92607e825c727e0c9b0/.github/workflows/test-notebooks.yml#L108

Those uploads should either be removed (if they are determined to be unused) or switched to using the GitHub Actions artifact store.

Benefits of this work

  • another step towards removing downloads.rapids.ai completely
  • would allow contributors who don't work at NVIDIA to access those test result outputs from CI

Acceptance Criteria

  • this repo does not depend on downloads.rapids.ai in any way
  • docs accurately reflect artifact-handling in this repo

Approach

Try using actions/upload-artifact in test workflows, similar to this:

https://github.com/rapidsai/shared-workflows/blob/d87850d9ccd0c6b1c610a0bf533e1acf1731f844/.github/workflows/wheels-build.yaml#L272-L277

Notes

N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/workflows/test-notebooks.yml around line 108 and search this repository for downloads.rapids.ai references. Compare the notebook workflow with the shared-workflows wheels-build.yaml artifact example. Done means the repository no longer depends on downloads.rapids.ai and its documentation accurately describes artifact handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.