rapidsai / rapidsai/devcontainers

devcontainer clang-format version should match RAPIDS pre-commit requirements

Open
#55 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
28
Forks
47
Avg merge
2d 41m
Merged PRs (30d)
15

Description

Currently just about every time I push to CI my PRs fail clang-format checks because the clang-format in the devcontainer (cuSpatial) is v16, and RAPIDS pre-commit uses something like v11. Small things like bracket wrapping and comment alignment have changed between versions.

Would be nice for these to align.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the cuSpatial devcontainer's clang-format version with the RAPIDS pre-commit requirements mentioned in the issue, starting with the devcontainer and pre-commit configuration. Align the versions so formatting checks use the same release, then verify that the relevant CI clang-format checks pass.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.