rapidsai / rapidsai/cugraph

pylibcugraph needs to check all error codes from the C API and raise appropriate exceptions

Open
#3,545 1 comment 0 reactions 2 assignees View on GitHub

@jnke2016 is already working on this.

Since May 28, 2024.

feature request
Dominant language
Cuda
Stars
2.2k
Forks
369
Avg merge
2d 14h
Merged PRs (30d)
36

Description

PR #3533 enables additional checks in the C++ library which may result in errors being returned to pylibcugraph. pylibcugraph currently is not checking for these errors, and the uncaught exception from C++ results in a crash with a stack trace from C++, showing the following:

E   RuntimeError: non-success value returned from cugraph_sg_graph_create_from_csr(): CUGRAPH_UNKNOWN_ERROR cuGraph failure at file=/__w/cugraph/cugraph/cpp/src/structure/create_graph_from_edgelist_impl.cuh line=907: Invalid input arguments: graph_properties.is_symmetric is true but the input edge list is not symmetric.

Instead, pylibcugraph should catch exceptions and/or check all error codes from the C API and raise appropriate exceptions.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.