Add annotation for Advice to annotate placeholder methods in the same class
Open
@raphw is already working on this.
Since Jun 3, 2018.
enhancement
- Dominant language
- Java
- Stars
- 6.9k
- Forks
- 855
- PR merge metrics
- No merged PRs in 30d
Description
It should be possible to annotate methods in the class of an advice class that are used to represent another available method such as a private method or a super method that cannot be represented in the template byte code. For example:
class MyAdvice {
@Advice.OnMethodEnter
static void advice(@Advice.This Foo self) {
somePrivateMethod(self, "abc");
}
@Advice.Substitute(target = Foo.class, name = "bar")
static void somePrivateMethod(Foo self, String arg) { }
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.