raphamorim / raphamorim/rio

[Bug] Disabling window decorations broken on Windows

Open
#418 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
7.5k
Forks
353
Avg merge
2d 11h
Merged PRs (30d)
15

Description

The feature implemented in #384 seems to be broken. Even with:

[window]
decorations = "Disabled"

... The window still has all the normal decorations and does not match the screenshot in #384.

My environment:

OS: Windows 11 Pro 23H2, 22631.3007
Rio version: rel v0.0.34

entire config:

config.toml

cursor = '▇'
blinking-cursor = false

ignore_theme_selection_fg_color = false

performance = "High"

[window]
decorations = "Disabled"

[fonts]
family = "SauceCodePro Nerd Font"
size = 20
[fonts.regular]
weight = 400
[fonts.bold]
weight = 600
[fonts.italic]
weight = 400
[fonts.bold-italic]
weight = 600

[navigation]
mode = "BottomTab"
clickable = true
use-current-path = true
# color-automation = []
# macos-hide-window-buttons = true

[shell]
program = "nu.exe"
args = []

[colors]
tabs = '#111111'
tabs-active = '#5500AA'
cursor = '#00DD00'
selection-foreground = '#000000'
selection-background = '#AAAA00'

[bindings]
keys = [
	# Disable most defaults
	{ key = ",", with = "control | shift", action = "ReceiveChar" },
	{ key = "space", with = "alt | shift", action = "ReceiveChar" },
	{ key = "n", with = "control | shift", action = "ReceiveChar" },
	{ key = "t", with = "control | shift", action = "ReceiveChar" },
	{ key = "tab", with = "control", action = "ReceiveChar" },
	{ key = "]", with = "control | shift", action = "ReceiveChar" },
	{ key = "tab", with = "control | shift", action = "ReceiveChar" },
	{ key = "[", with = "control | shift", action = "ReceiveChar" },
	{ key = "0", with = "control", action = "ReceiveChar" },
	{ key = "w", with = "control | shift", action = "ReceiveChar" },

	# Keybinds I actually want
	{ key = "c", with = "control | shift", action = "Copy" },
	{ key = "v", with = "control | shift", action = "Paste" },
	{ key = "=", with = "control", action = "IncreaseFontSize" },
	{ key = "-", with = "control", action = "DecreaseFontSize" },
	{ key = "n", with = "alt | shift", action = "CreateWindow" },
	{ key = "t", with = "alt", action = "CreateTab" },
	{ key = "1", with = "alt", action = "SelectTab(0)" },
	{ key = "2", with = "alt", action = "SelectTab(1)" },
	{ key = "3", with = "alt", action = "SelectTab(2)" },
	{ key = "4", with = "alt", action = "SelectTab(3)" },
	{ key = "5", with = "alt", action = "SelectTab(4)" },
	{ key = "6", with = "alt", action = "SelectTab(5)" },
	{ key = "7", with = "alt", action = "SelectTab(6)" },
	{ key = "8", with = "alt", action = "SelectTab(7)" },
	{ key = "9", with = "alt", action = "SelectTab(8)" },
	{ key = "0", with = "alt", action = "SelectTab(9)" },
	{ key = "pageup", with = "alt", action = "ScrollHalfPageUp" },
	{ key = "pagedown", with = "alt", action = "ScrollHalfPageDown" },
]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on Windows with the supplied config.toml and the [window] decorations = "Disabled" setting, then inspect the window-decoration feature implemented in #384. Compare the result with the screenshot linked there; done means Rio opens without the normal Windows decorations under this setting.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.