randombit / randombit/botan

configure.py drops build.ninja in the repository root

Open
#4,232 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

build problem usage question
Dominant language
C++
Stars
3.3k
Forks
663
Avg merge
1d 2h
Merged PRs (30d)
56

Description

Reproduction steps (Win10, VS2022, Python 3.12):

  • Open x64 Native Tools Command Prompt for VS 2022
  • Navigate to the folder where botan is cloned (git describe results in 1.11.30-9833-gb8af12b5c)
  • python3 configure.py --cc=msvc --os=windows --build-tool=ninja --prefix=build/install --disable-shared-library

The build.ninja is placed in the repository root instead of in the build folder

This results in some build artifacts also being dropped in the repository root (when building):

dir /B
.clang-format
.github
.gitignore
.ninja_deps
.ninja_log
botan-3.lib
botan-cli.exe
botan-test.exe
build
build.ninja
configure.py
doc
license.txt
news.rst
readme.rst
src

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in configure.py and reproduce the reported Windows command with --build-tool=ninja and the build directory settings. Trace where the Ninja build file and build artifacts are written; the fix is complete when build.ninja and generated artifacts are placed under build rather than the repository root.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.