A typo in Part 11 in the testcases of exercise 7

Open Beginner friendly
#74 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
92/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
testing

Research direction

Find the Part 11 exercise 7 testcase containing test_9a_test_hits_in_place_with_values_1 and test_9b_test_hits_in_place_with_values_2. Review the expected corr arrays against the shown test_case and correct the two reported typos, then run the relevant exercise tests to confirm they pass.

Written by the indexing model from the issue text.

Description

In test case 9a, the last index of corr should be -1 as 11 != 13:

@points('11.lottery_numbers_part2')
def test_9a_test_hits_in_place_with_values_1(self):
test_case = [1,2,5,6,9,10,11]
correct = [1,3,5,7,9,11,13]
corr = [1,-1,5,-1,9,-1,11]
from src.lottery_numbers import LotteryNumbers
row = LotteryNumbers(1, correct)
val = row.hits_in_place(test_case[:])

In test case 9b, 7 != 8 and 33 != 32:

@points('11.lottery_numbers_part2')
def test_9b_test_hits_in_place_with_values_2(self):
test_case = [4,6,8,10,30,32,34]
correct = [5,6,7,8,32,33,34]
corr = [-1,6,8,-1,-1,32,34]
from src.lottery_numbers import LotteryNumbers
row = LotteryNumbers(1, correct)
val = row.hits_in_place(test_case[:])

Dominant language
JavaScript
Stars
77
Forks
30
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rage/programming-26

All issues in rage/programming-26

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.