racket / racket/typed-racket

Perf regression on with-tr-contracts test.

Open
#313 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Racket
Stars
575
Forks
106
Avg merge
2h 1m
Merged PRs (30d)
2

Description

From the DrDr timing info it look like one of these three commits made the with-tr-contracts.rkt test 5 minutes slower (about 25%).

  • da574a47d06a8c8f2ed4d88b9c916b1b7075b3ef, 5d4477d08de9956e012fde87f41d8e652c162fa1, 67bd07a84a2317eba5583302ca38ede7c156c08d

They're by me, @bennn, and @jsmaniac respectively. We should figure out why one of them had such a big impact.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the DrDr timing report for typed-racket-test/with-tr-contracts.rkt and compare the three listed commits: da574a47d06a8c8f2ed4d88b9c916b1b7075b3ef, 5d4477d08de9956e012fde87f41d8e652c162fa1, and 67bd07a84a2317eba5583302ca38ede7c156c08d. Determine which commit caused the roughly five-minute slowdown and identify why the test became about 25% slower; done means the regression is explained and addressed.

Written by the indexing model from the issue text.

Assessment

Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.