racket / racket/typed-racket

In nested if, eq? breaks occurrence typing

Open
#252 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Racket
Stars
575
Forks
106
Avg merge
2h 1m
Merged PRs (30d)
2

Description

The code below does not typecheck (and expands to such code):

(λ ([val : (U (List 'x 'y) (List 'z))])
  (if (if (pair? (cdr val))
          (eq? 'x (car val))
          #f)
      (ann val (List 'x 'y))
      (ann val (List 'z)))) ;; TR says val is (U (List 'x 'y) (List 'z)) here

If we wrap the (eq? 'x (car val)) with an (if … #t #f), it typechecks without problem:

(λ ([val : (U (List 'x 'y) (List 'z))])
  (if (if (pair? (cdr val))
          (if (eq? 'x (car val))
              #t
              #f)
          #f)
      (ann val (List 'x 'y))
      (ann val (List 'z)))) ;; Okay

This last example shows that wrapping the eq? with (if … #t #f) is not enough if the eq? further refines the type.

(λ ([val : (U (List 'x 'y) (List 'x 'w) (List 'z))])
  (if (if (eq? 'x (car val))
          (if (eq? 'y (cadr val)) #t #f)
          #f)
      (ann val (List 'x 'y))
      (ann val (U (List 'x 'w) (List 'z))))) ;; TR says val is (U (List x y) (List x w) (List z)) here

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the three Typed Racket reproductions in the issue and compare occurrence-typing behavior for nested if expressions involving pair?, eq?, car, and cadr. Done means the examples typecheck while retaining the expected refined types in both branches.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.