scriblib/footnote broken

Open

#49 opened on Jul 21, 2016 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language: Racket
Stars: 250
Forks: 102
Avg merge: 11d 11h
Merged PRs (30d): 1

Description

This program:

#lang scribble/base
@(require scriblib/footnote)
@(define-footnote footnote footnote-part)
abc@footnote{abc}

raises this error:

$ scribble --pdf tmp.scrbl
hash-ref: no value found for key
  key: (generated-tag)
  context...:
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/core.rkt:605:0: tag-key
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/core.rkt:24:0: resolve-get/where
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/core.rkt:62:0: resolve-get
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/base-render.rkt:758:4: resolve-content method in render%
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/base-render.rkt:758:4: resolve-content method in render%
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/base-render.rkt:758:4: resolve-content method in render%
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/base-render.rkt:758:4: resolve-content method in render%
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/base-render.rkt:758:4: resolve-content method in render%
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/base-render.rkt:758:4: resolve-content method in render%
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/base-render.rkt:725:4: resolve-flow method in render%
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/base-render.rkt:713:4: resolve-part method in render%
   loop
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/base-render.rkt:705:4: resolve method in render%
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/render.rkt:33:0: render57
   /Users/robby/git/plt/racket/collects/racket/contract/private/arrow-val-first.rkt:397:3
   /Users/robby/git/plt/extra-pkgs/scribble/scribble-lib/scribble/run.rkt: [running body]

This program worked in 5.3.3, but not in 5.3.4.

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Reproduce the minimal example with scribble --pdf tmp.scrbl, then inspect scriblib/footnote and the tag-key and resolve-content paths named in scribble/core.rkt and scribble/base-render.rkt. Done means the example renders without the (generated-tag) error, preserving the behavior that worked in 5.3.3.

Written by the indexing model from the issue text.

Assessment

Domain: documentation, tooling
Issue type: Bug
Difficulty: 3/5
Estimated time: 1-2 days
Activity status: Stale
Clarity: Mostly clear
Newbie friendliness: 35/100