racket / racket/rhombus

`pin` reports that a picture isn't found when it is there multiple times (instead of reporting it is ambiguous)

Open
#759 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Racket
Stars
601
Forks
74
Avg merge
2d 10h
Merged PRs (30d)
5

Description

This program:

#lang rhombus
import:
  pict open

def par_bars = square()
def combined = stack(par_bars, par_bars)
def ell = circle()
//Find.center(par_bars).in(combined)
pin(ell,
    ~on: combined,
    ~at: Find.center(par_bars))

produces the error

pin: cannot find pict
  finder: Find()

but par_bars is actually there twice and if you remove the line comment on the call to in, then you'll get the right error:

Find.in: pict location is ambigious
  pict: Pict("square", 21132465)

Also, the finder: line prints the finder just as Find() which seems like it might be a place where there is a straightforward improvement to be had.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the supplied Rhombus reproduction and compare the pin call with the uncommented Find.center(par_bars).in(combined) call. Trace the pin, Find.center, and Find.in entry points; done means repeated picts produce the existing ambiguity error instead of “cannot find pict,” with the finder description improvement evaluated separately.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.