racket / racket/racket

Large number of errors from new version format checking

Open
#4,630 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component: package release-management
Dominant language
Racket
Stars
5.2k
Forks
698
Avg merge
18h 34m
Merged PRs (30d)
5

Description

Coming in 8.9, Racket now checks that package versions conform to valid-version?. This was added by @Bogdanp in https://github.com/racket/racket/pull/4588.

The current status is that this flags an error in the 56 packages listed below. This is fewer than it was before, thanks to the extensive set of PRs that @Bogdanp filed (you can see them linked from the original pull request). That seems like a lot. A high percentage of them are versions of the form N.N.0, which is not allowed. I wonder if relaxing the rules slightly here would be beneficial.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the version-checking change in pull request 4588 and the linked package reports, especially the entries using N.N.0 versions. Compare those cases with the behavior of valid-version? and determine whether the rules should change. Done means reaching a decision on the proposed relaxation and covering the resulting behavior for the affected package set.

Written by the indexing model from the issue text.

Assessment

Domain
release
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.