rabbitmq / rabbitmq/rabbitmq-java-client
There is no RecoveryCallback counterpart for RecoveryListener
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.3k
- Forks
- 587
- Avg merge
- 7h 29m
- Merged PRs (30d)
- 41
Description
This is based on 5.5.0.
When implementing a recovery listener, I noticed that there is no RecoveryCallback counterpart for a RecoveryListener, to support lambda style of registering a callback. For most listeners (ShutdownListener, ConfirmListener, ...) we have such counterpart.
Is this something we want to add?
I'm happy to create a PR for this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating RecoveryListener and compare it with the existing callback counterparts for ShutdownListener and ConfirmListener. Confirm the intended lambda-registration pattern and identify the relevant tests; done means RecoveryListener has a matching RecoveryCallback counterpart with coverage for callback registration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100