Implement `s2_rebuild_together()`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 81
- Forks
- 19
- Avg merge
- 20h 25m
- Merged PRs (30d)
- 3
Description
Right now s2_rebuild() treats all inputs as separate, which can result in problems when simplifying layers like polygon coverages and contour lines where creating new crossing edges would invalidate the layer topology. S2 provides a mechanism to rebuild multiple features together without creating new crossing edges which we should implement here: https://github.com/google/s2geometry/blob/master/src/s2/s2builder.h#L113-L117 .
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing s2_rebuild() implementation and the linked S2Builder documentation for rebuilding multiple features together. Implement s2_rebuild_together() so polygon coverages and contour lines can be simplified without creating crossing edges, then verify the affected topology behavior with the project's existing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100