Implicit and naive cloning of comparable objects causes errors
Open
Nobody has claimed this yet.
Component: Assert
Type: Bug
- Dominant language
- JavaScript
- Stars
- 4k
- Forks
- 773
- PR merge metrics
- No merged PRs in 30d
Description
const object = { get x() { throw 42 }};
assert.equal(object, object); // => Died on test qunitjs/node-qunit#1: 42
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the JavaScript snippet in the QUnit assertion tests and trace how assert.equal compares objects with getters. Determine the intended behavior for a comparable object whose getter throws, then add a regression test showing that behavior and run the relevant assertion tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100