deepEqual should not compare constructors
Open
Nobody has claimed this yet.
Component: Assert
- Dominant language
- JavaScript
- Stars
- 4k
- Forks
- 773
- PR merge metrics
- No merged PRs in 30d
Description
Currently, deepEqual will do a strict equality comparison on the constructor of each value. This defeats the purpose of deepEqual in that it prevents it from matching structurally, and leads to the myriad of issue reported in qunit over the years around comparisons of Array vs TypedArray and the like.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the JavaScript source for the deepEqual implementation and read its nearby comparison tests first. Confirm the completed change by checking that structural comparisons no longer depend on constructors, including the Array versus TypedArray cases described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100